add new feats #250
add new feats #250
Conversation
1.18/animation test
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -45,6 +46,8 @@ | |||
| @OnlyIn(Dist.CLIENT) | |||
| public class SignalCustomModel implements UnbakedModel { | |||
|
|
|||
| private static final Map<ResourceLocation, BakedModel> locationToModel = new HashMap<>(); | |||
There was a problem hiding this comment.
Name 'locationToModel' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.
| } | ||
|
|
||
| private final Map<BakedModel, Entry<ModelTranslation, List<SignalAnimation>>>// | ||
| animationPerModel = new HashMap<>(); |
There was a problem hiding this comment.
'animationPerModel' has incorrect indentation level 4, expected level should be 8.
| private final float animationSpeed; | ||
| private final VectorWrapper dest; | ||
|
|
||
| public SignalAnimationTranslation(Predicate<ModelInfoWrapper> predicate, |
There was a problem hiding this comment.
Parameter predicate should be final.
| private void buildRenderListForAnimations(final Signal signal, final ModelInfoWrapper wrapper) { | ||
| animationInfos.clear(); | ||
| final Map<Entry<String, VectorWrapper>, List<SignalAnimation>> // | ||
| map = SignalAnimationConfigParser.ALL_ANIMATIONS.get(signal); |
There was a problem hiding this comment.
'map' has incorrect indentation level 8, expected level should be 12.
| private static final Gson GSON = new Gson(); | ||
|
|
||
| public static final Map<Signal, Map<Entry<String, VectorWrapper>, List<SignalAnimation>>>// | ||
| ALL_ANIMATIONS = new HashMap<>(); |
There was a problem hiding this comment.
'ALL_ANIMATIONS' has incorrect indentation level 4, expected level should be 8.
No description provided.