Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.18/animation test #249

Merged
merged 27 commits into from
Nov 5, 2024
Merged

1.18/animation test #249

merged 27 commits into from
Nov 5, 2024

Conversation

Uhutown
Copy link
Collaborator

@Uhutown Uhutown commented Nov 5, 2024

No description provided.

@Uhutown Uhutown merged commit 360203b into feats/1.18 Nov 5, 2024
3 of 5 checks passed
@Uhutown Uhutown deleted the 1.18/animationTest branch November 5, 2024 13:55
@@ -45,6 +46,8 @@
@OnlyIn(Dist.CLIENT)
public class SignalCustomModel implements UnbakedModel {

private static final Map<ResourceLocation, BakedModel> locationToModel = new HashMap<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [Checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.ConstantNameCheck> reported by reviewdog 🐶
Name 'locationToModel' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.

}

private final Map<BakedModel, Entry<ModelTranslation, List<SignalAnimation>>>//
animationPerModel = new HashMap<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [Checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'animationPerModel' has incorrect indentation level 4, expected level should be 8.

private final float animationSpeed;
private final VectorWrapper dest;

public SignalAnimationTranslation(Predicate<ModelInfoWrapper> predicate,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [Checkstyle] <com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck> reported by reviewdog 🐶
Parameter predicate should be final.

private void buildRenderListForAnimations(final Signal signal, final ModelInfoWrapper wrapper) {
animationInfos.clear();
final Map<Entry<String, VectorWrapper>, List<SignalAnimation>> //
map = SignalAnimationConfigParser.ALL_ANIMATIONS.get(signal);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [Checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'map' has incorrect indentation level 8, expected level should be 12.

private static final Gson GSON = new Gson();

public static final Map<Signal, Map<Entry<String, VectorWrapper>, List<SignalAnimation>>>//
ALL_ANIMATIONS = new HashMap<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [Checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ALL_ANIMATIONS' has incorrect indentation level 4, expected level should be 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants