Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

adds polyfill sourcemap #115

Merged
merged 1 commit into from
Feb 8, 2018
Merged

adds polyfill sourcemap #115

merged 1 commit into from
Feb 8, 2018

Conversation

caseyyee
Copy link
Contributor

@caseyyee caseyyee commented Feb 7, 2018

Fix #54
also moves this into the main templates folder.

just to be consistent with all the other library usage.

probably time to add a js folder

As a note, Polyfill ver:
https://github.com/immersive-web/webvr-polyfill/releases/tag/v0.9.36

@caseyyee caseyyee requested a review from cvan February 7, 2018 08:04
@caseyyee
Copy link
Contributor Author

caseyyee commented Feb 7, 2018

ok took materials.meta and models.meta

@delapuente delapuente added this to the Community release milestone Feb 7, 2018
@cvan
Copy link
Contributor

cvan commented Feb 7, 2018

@caseyyee I see this in Safari on iOS:

image
image

@delapuente
Copy link
Contributor

I think that's out of reach. The Unity player exhausts device memory. This is also happening in Chrome and Firefox from time to time.

@delapuente
Copy link
Contributor

Well, not out of reach but it requires optimizing the Unity loader and probably do more than JS to fix it.

@cvan
Copy link
Contributor

cvan commented Feb 7, 2018

you can manually bump the memory size from the Unity WebGL Player Settings or the emscripten module loader options in index.html

@delapuente
Copy link
Contributor

This is duplicating #54 according to the current wording. I'm going to close that and test and merge this.

For the posterity:

  1. We'll add an out-of-memory-related entry in the FAQ
  2. We are tracking how to update the polyfill in upgrade version of webvr-polyfill dependency #113

If you see the error regarding requestAnimationFrame and described here, open another issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants