Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fix resize mode visible on top of settings #900

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Fix resize mode visible on top of settings #900

merged 1 commit into from
Dec 20, 2018

Conversation

MortimerGoro
Copy link
Contributor

Fixes #895

@MortimerGoro MortimerGoro requested a review from cvan December 18, 2018 15:44
@MortimerGoro MortimerGoro self-assigned this Dec 18, 2018
@bluemarvin
Copy link
Contributor

I'm pretty sure this will happen with any dialog and not just the settings. However I'm not actually sure that you can be in resize mode and have another dialog come up. Maybe a better solution is to hide the tray while in resize mode?

@keianhzo
Copy link
Contributor

+1 hiding the tray will avoid any conflicts plus we are already hiding it for fullscreen mode.

@MortimerGoro
Copy link
Contributor Author

Done! Ready for review

@bluemarvin bluemarvin merged commit d32cabc into master Dec 20, 2018
@bluemarvin bluemarvin deleted the resize_settings branch December 20, 2018 19:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bluemarvin bluemarvin bluemarvin approved these changes

@cvan cvan Awaiting requested review from cvan

Assignees

@MortimerGoro MortimerGoro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MortimerGoro @bluemarvin @keianhzo