This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fixes #1857 Added option to disable domain autocomplete in the address bar #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've made some comments in the issue. I'm not sure we have the correct spec for this feature. |
keianhzo
force-pushed
the
v8/autocomplete
branch
from
d0275a7 to
86d3582
Compare
|
@bluemarvin @MortimerGoro I guess we should close this one? |
I think we want the functionality, but we need to resolve how the auto suggestion code should work. |
|
We added a toggle to the design, but we didn't add it to this issue. See screenshot and design notes below.
|
|
@emstanley I think we talked about moving this one to v11? I think the functionality is not clear at this point, we probably will need to go over this one to redefine it. |
|
Closing in favor of #3551 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1857 Added a privacy setting to enable/disable the history/bookmarks based autocomplete in the awesome bar.