Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fixes #2529 Better L10n support in settings #2609

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Fixes #2529 Better L10n support in settings #2609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/res/layout/options_footer.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<RelativeLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_height="match_parent"
android:gravity="center">

<View
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/options_header.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_height="match_parent"
android:orientation="vertical">

<RelativeLayout
Expand Down
6 changes: 4 additions & 2 deletions app/src/main/res/layout/setting_button.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@

<LinearLayout
android:layout_width="match_parent"
android:layout_height="@dimen/developer_options_row_width"
android:layout_height="match_parent"
android:paddingTop="5dp"
android:paddingBottom="5dp"
android:orientation="vertical">

<RelativeLayout
Expand All @@ -19,7 +21,7 @@
android:layout_marginEnd="10dp"
android:layout_toStartOf="@+id/button"
android:gravity="center_vertical"
tools:text="Edit Setting Description" />
tools:text="@string/privacy_options_popups_reset" />

<TextView
android:id="@+id/button"
Expand Down
4 changes: 3 additions & 1 deletion app/src/main/res/layout/setting_edit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@

<LinearLayout
android:layout_width="match_parent"
android:layout_height="@dimen/developer_options_row_width"
android:layout_height="match_parent"
android:paddingTop="5dp"
android:paddingBottom="5dp"
android:orientation="vertical">

<RelativeLayout
Expand Down
4 changes: 3 additions & 1 deletion app/src/main/res/layout/setting_radio_group.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@

<LinearLayout
android:layout_width="match_parent"
android:layout_height="@dimen/developer_options_row_width"
android:layout_height="match_parent"
android:paddingTop="5dp"
android:paddingBottom="5dp"
android:orientation="vertical">

<RelativeLayout
Expand Down
6 changes: 4 additions & 2 deletions app/src/main/res/layout/setting_radio_group_v.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@

<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_height="match_parent"
android:paddingTop="5dp"
android:paddingBottom="5dp"
android:orientation="vertical">

<RelativeLayout
Expand All @@ -17,7 +19,7 @@
android:layout_alignParentStart="true"
android:layout_alignParentTop="true"
android:layout_centerVertical="true"
android:layout_marginBottom="20dp"
android:layout_marginBottom="10dp"
tools:text="Radio Setting Description" />

<RadioGroup
Expand Down
4 changes: 3 additions & 1 deletion app/src/main/res/layout/setting_switch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
<LinearLayout
android:id="@+id/layout"
android:layout_width="match_parent"
android:layout_height="@dimen/developer_options_row_width"
android:layout_height="match_parent"
android:paddingTop="5dp"
android:paddingBottom="5dp"
android:orientation="vertical">

<RelativeLayout
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/dimen.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@
<dimen name="options_height">385dp</dimen>

<!-- Developer Panel -->
<dimen name="options_button_width">120dp</dimen>
<dimen name="options_button_width">140dp</dimen>
<dimen name="options_button_height">30dp</dimen>
<dimen name="options_text_height">30dp</dimen>
<dimen name="developer_options_row_width">40dp</dimen>
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@

<style name="settingsButtonDescriptionText">
<item name="android:layout_width">wrap_content</item>
<item name="android:layout_height">@dimen/options_text_height</item>
<item name="android:layout_height">wrap_content</item>
<item name="android:gravity">center</item>
<item name="android:textColor">@color/fog</item>
<item name="android:textSize">@dimen/text_medium_size</item>
Expand Down