Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Set correct Oculus WebVR device name #1032

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Set correct Oculus WebVR device name #1032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/src/oculusvr/cpp/DeviceDelegateOculusVR.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,11 @@ DeviceDelegateOculusVR::RegisterImmersiveDisplay(ImmersiveDisplayPtr aDisplay) {
return;
}

m.immersiveDisplay->SetDeviceName("Oculus");
if (m.IsOculusQuest()) {
m.immersiveDisplay->SetDeviceName("Oculus Quest");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to prepare for the WebXR Device API (which intentionally does not expose identifier strings for devices), shouldn't we begin deprecating VRDisplay#displayName?

Copy link
Contributor

@daoshengmu daoshengmu Mar 18, 2019 •
edited by philip-lamb
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks correct compared to Oculus browser.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good to know that we have parity with the Oculus Browser. in that case, we can defer deprecating the device string until WebXR is implemented (in both browsers) and web-compatibility isn't affected.

} else {
m.immersiveDisplay->SetDeviceName("Oculus Go");
}
uint32_t width, height;
m.GetImmersiveRenderSize(width, height);
m.immersiveDisplay->SetEyeResolution(width, height);
Expand Down