Make RootWidget focus more reliable. Fixes #2055.

MozillaReality · Oct 25, 2019 · 2bdeb14 · 2bdeb14
1 parent 33fbbff
commit 2bdeb14
Showing 1 changed file with 24 additions and 8 deletions.
diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/RootWidget.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/RootWidget.java
@@ -2,10 +2,11 @@
 
 import android.content.Context;
 import android.util.AttributeSet;
-import android.view.View;
+import android.view.MotionEvent;
 
 public class RootWidget extends UIWidget {
     private Runnable mOnClickCallback;
+    private boolean mTouched = true;
 
     public RootWidget(Context aContext) {
         super(aContext);
@@ -31,14 +32,29 @@ protected void initializeWidgetPlacement(WidgetPlacement aPlacement) {
 
     private void initialize(Context aContext) {
         setFocusable(true);
+    }
 
-        setOnClickListener(v -> {
-            requestFocus();
-            requestFocusFromTouch();
-            if (mOnClickCallback != null) {
-                mOnClickCallback.run();
-            }
-        });
+    @Override
+    public boolean onTouchEvent(MotionEvent event) {
+        switch (event.getAction()) {
+            case MotionEvent.ACTION_DOWN:
+                mTouched = true;
+                break;
+            case MotionEvent.ACTION_UP:
+                if (mTouched) {
+                    mTouched = false;
+                    requestFocus();
+                    requestFocusFromTouch();
+                    if (mOnClickCallback != null) {
+                        mOnClickCallback.run();
+                    }
+                }
+                break;
+            case MotionEvent.ACTION_CANCEL:
+                mTouched = false;
+                break;
+        }
+        return super.onTouchEvent(event);
     }
 
     public void setClickCallback(Runnable aRunnable) {