Close menu dropdown on scroll offset update #13310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmmavis
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Hey @ramram-mf , Thanks for the fix! It works great! I left one suggestion for improvement. If it looks good to you, please apply the code change and merge the PR. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the behavior of the desktop main navigation dropdown so that it repositions when scrolled and the top offset changes. This new behavior wont apply when its in the top fixed position, including cases when the donate banner is closed or when it has scrolled past it.
Current state
Fixed state
Link to sample test page: https://foundation-s-tp1-1703-d-hoermc.herokuapp.com/en/
Related PRs/issues: #13299