Rendering EOY banner on donate pages #13307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfmiranda
temporarily deployed
to
foundation-s-hotfix-don-bqcn2a
danielfmiranda
commented
Dec 12, 2024
danielfmiranda
commented
Dec 12, 2024
danielfmiranda
commented
Dec 12, 2024
dlopezvsr
approved these changes
Dec 12, 2024
danielfmiranda
temporarily deployed
to
foundation-s-hotfix-don-38eehi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue: https://mozilla-hub.atlassian.net/browse/TP1-1477
I found that donate related pages such as donate, /donate/help, and /donate/ways-to-give were not rendering the EOY donate banner. This was because they did not inherit from the class
BasePage.This PR updates the
BaseDonationPageclass to inherit fromBasePageto utilizeBasePage's methodget_donate_banner(), which adds the EOY donate banner related information to the page context for rendering it on the frontend.This PR also imports
resets.scssindonate-main.scss, which the EOY banner uses to render its featured image in the appropriate dimensions.Steps to test