Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage refresh new intro section #12858

Merged
merged 32 commits into from
Sep 23, 2024

Conversation

ramram-mf
Copy link
Collaborator

@ramram-mf ramram-mf commented Sep 11, 2024

Description

This PR updates the homepage model and view, adding a new section below the hero banner, with editable heading, contents, cta and page target. Repositions the Focus areas section into it and updates all styling to tailwind utility classes.

image

Mobile layout ATF

image

Mobile layout BTF

image

Desktop layout

image

Wagtail page form UI

To test

  1. Login to the review app CMS with credentials admin2:admin2
  2. Update the homepage new section hero bottom fields, publish.
  3. Review the homepage and confirm changes were reflected correctly.

Link to sample test page: https://foundation-s-tp1-930-ho-hg3if5.herokuapp.com/
Related PRs/issues: #12598

┆Issue is synchronized with this Jira Story

@ramram-mf ramram-mf self-assigned this Sep 11, 2024
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-cn1vtu September 11, 2024 05:46 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-cn1vtu September 11, 2024 05:59 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-tp1-930-ho-rqpwjc September 11, 2024 06:01 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-rqpwjc September 11, 2024 06:29 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-rqpwjc September 11, 2024 06:31 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-rqpwjc September 11, 2024 06:44 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-rqpwjc September 11, 2024 06:50 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-rqpwjc September 11, 2024 06:58 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-rqpwjc September 11, 2024 07:03 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-rqpwjc September 11, 2024 07:22 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-rqpwjc September 11, 2024 17:52 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-rqpwjc September 11, 2024 17:56 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-rqpwjc September 11, 2024 18:34 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-rqpwjc September 17, 2024 19:29 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-dirrs7 September 17, 2024 20:45 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-dirrs7 September 18, 2024 17:29 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-dirrs7 September 18, 2024 17:52 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-dirrs7 September 19, 2024 17:12 Inactive
@danielfmiranda danielfmiranda self-requested a review September 19, 2024 18:07
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-dirrs7 September 19, 2024 20:18 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-dirrs7 September 19, 2024 21:44 Inactive
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ramram-mf,

Thank you for taking on this task! I followed the steps in your description, and everything is functioning as expected. Great work! 🙌

I do have one key suggestion regarding the fields hero_intro_link_text and hero_intro_link_page. Given the recent push to use it wherever possible, we can simplify these fields by combining them into a single field using the LinkBlock, as it handles both link label and link target along with any necessary validation. It also allows users to set the link target to not only internal pages, but also external links, phone numbers, emails, etc:

Screenshot 2024-09-19 at 11-49-22 Editing Homepage Homepage - Wagtail

I’ve left suggestions in the review to show how you could implement this change in your PR. If you need any help, please feel free to reach out and I would be happy to help via slack or zoom call! 👍

Additionally, you can check out this PR for reference, where we’ve implemented the LinkBlock in a similar context.

Thanks again, and great job on the progress so far!

@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-dirrs7 September 20, 2024 08:37 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-dirrs7 September 20, 2024 09:01 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-930-ho-fxq6ak September 23, 2024 19:49 Inactive
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks @ramram-mf! Approved 👍

@mofodevops mofodevops temporarily deployed to foundation-s-tp1-930-ho-hg3if5 September 23, 2024 19:51 Inactive
@ramram-mf ramram-mf merged commit 961cf16 into main Sep 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants