-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homepage refresh new intro section #12858
Homepage refresh new intro section #12858
Conversation
…ocusArea` model
…ted FocusArea objects
…ntro" section accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ramram-mf,
Thank you for taking on this task! I followed the steps in your description, and everything is functioning as expected. Great work! 🙌
I do have one key suggestion regarding the fields hero_intro_link_text
and hero_intro_link_page
. Given the recent push to use it wherever possible, we can simplify these fields by combining them into a single field using the LinkBlock, as it handles both link label and link target along with any necessary validation. It also allows users to set the link target to not only internal pages, but also external links, phone numbers, emails, etc:
I’ve left suggestions in the review to show how you could implement this change in your PR. If you need any help, please feel free to reach out and I would be happy to help via slack or zoom call! 👍
Additionally, you can check out this PR for reference, where we’ve implemented the LinkBlock in a similar context.
Thanks again, and great job on the progress so far!
network-api/networkapi/wagtailpages/templates/wagtailpages/fragments/hero_intro_box.html
Outdated
Show resolved
Hide resolved
…ro_intro_xxxx` data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, thanks @ramram-mf! Approved 👍
Description
This PR updates the homepage model and view, adding a new section below the hero banner, with editable heading, contents, cta and page target. Repositions the
Focus areas
section into it and updates all styling to tailwind utility classes.Mobile layout ATF
Mobile layout BTF
Desktop layout
Wagtail page form UI
To test
admin2:admin2
hero bottom
fields, publish.Link to sample test page: https://foundation-s-tp1-930-ho-hg3if5.herokuapp.com/
Related PRs/issues: #12598
┆Issue is synchronized with this Jira Story