Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary heroguts template divided, heroguts homepage created #12827

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

dlopezvsr
Copy link
Collaborator

@dlopezvsr dlopezvsr commented Sep 5, 2024

Description

This PR divides primary_heroguts.html into two use cases, where the previous "if statements" found together in the current version are separated accordingly. So heroguts_homepage.html was created to isolate HTML related to homepage.html and primary_heroguts.html left for primary_page.html and bannered_campaign_page.html

How to test

  • Go to homepage review app and make sure the hero banner still looks good for different viewports.
  • Go to some banner campaign page (example) and confirm same of previous point.

For banner page:
image

For homepage:
image

Link to sample test page: https://foundation-s-tp1-307-re-08hij9.herokuapp.com/en/
Related PRs/issues: #9605

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

┆Issue is synchronized with this Jira Story

@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-307-re-08hij9 September 6, 2024 17:41 Inactive
@dlopezvsr dlopezvsr self-assigned this Sep 6, 2024
@dlopezvsr dlopezvsr marked this pull request as ready for review September 6, 2024 18:54
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dlopezvsr,

Great work on this PR! 🎉 Thanks for taking this on, splitting out the templates will definitely make maintaining the different page types much smoother.

Your description and clear testing steps made reviewing and QA quite easy, so thanks also for that attention to detail.

I’ve walked through the code and followed the test instructions, and everything looks good to me. Approved! 👍

One quick note: I noticed the template names are a little different. One is called heroguts_homepage, while the other is primary_heroguts. It might be clearer if we rename the first one to homepage_heroguts for consistency. No need to hold this PR up, though—feel free to just make that change before merging this PR. Great job again!

@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-307-re-08hij9 September 11, 2024 02:26 Inactive
@dlopezvsr
Copy link
Collaborator Author

@danielfmiranda thank you so much for the review and the observation. It makes total sense to me and it's definitely clearer that rename. I just updated it in the last commit. 🙌

@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-307-re-08hij9 September 11, 2024 14:06 Inactive
@dlopezvsr dlopezvsr merged commit 40998f3 into main Sep 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants