Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DonateHelpPage's "notice" to be synchronized across translations #12825

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Sep 5, 2024

Description

Related PRs/issues: https://mozilla-hub.atlassian.net/browse/TP1-1081

This PR updates the DonateHelpPage's "notice" to a SynchronizedField.

Doing so will ensure that any changes to the notice will be synced across translations, fixing the issue mentioned in TP1-1081.

┆Issue is synchronized with this Jira Story

@danielfmiranda danielfmiranda changed the title Updated donate help page notice to be synchronized across translations Updated DonateHelpPage's "notice" to be synchronized across translations Sep 5, 2024
Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@robdivincenzo robdivincenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as well 😁

@danielfmiranda danielfmiranda merged commit 7b967f6 into main Sep 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants