Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNI - Closing the search bar on mobile should also clear search #12746

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Aug 28, 2024

Description

Notice now closing the search bar clears the search and brings users back to the "all products" view.

Screen.Recording.2024-08-29.at.10.09.58.AM.mov

Link to sample test page: https://foundation-s-tp1-123-10-9w9yxw.herokuapp.com/en/privacynotincluded/
Related PRs/issues: #10120

┆Issue is synchronized with this Jira Story

@mmmavis mmmavis temporarily deployed to foundation-s-tp1-123-10-9w9yxw August 28, 2024 22:40 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-tp1-123-10-9w9yxw August 29, 2024 17:11 Inactive
@mmmavis mmmavis requested a review from danielfmiranda August 29, 2024 17:12
@mmmavis mmmavis marked this pull request as ready for review August 29, 2024 17:12
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks @mmmavis 🙌 approved

@mmmavis mmmavis merged commit 76bafa9 into main Aug 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants