Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to PNI search related JS files #12742

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Aug 27, 2024

Description

Add documentation to functions in PNI's /search directory. I also left a few comments for future todos.

Related PRs/issues: #10170

┆Issue is synchronized with this Jira Story

@mmmavis mmmavis changed the title [WIP] Add documentation to PNI search related JS files Add documentation to PNI search related JS files Aug 28, 2024
@mmmavis mmmavis marked this pull request as ready for review August 28, 2024 22:05
@mmmavis mmmavis requested a review from danielfmiranda August 28, 2024 22:05
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @mmmavis 🙌

@mmmavis mmmavis merged commit 6d1497f into main Aug 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants