Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GTM ID #12739

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Replace GTM ID #12739

merged 4 commits into from
Aug 30, 2024

Conversation

dlopezvsr
Copy link
Collaborator

@dlopezvsr dlopezvsr commented Aug 26, 2024

Description

This PR replaces the current GTM container ID for a new one, created with the purpose of correcting the actual differences in donation numbers between GA and Salesforce. Inside this GTM container a proper integration with Fundraise Up was implemented.

How to test

In case an access to GA for testing purposes is needed, will have to be requested.

  • Once this changes are deployed in staging we will have to log into GA and GTM.
  • Go to https://analytics.google.com/analytics/web/ > login to dashboard
  • Open admin settings and on "Data display" section, > open "Events"
  • Search for the new tags added from GTM. You should be able to see: Fundraise Up Checkout Close, Fundraise Up Checkout Open, Fundraise Up Donation.

In GTM:

  • Log into https://tagmanager.google.com
  • Once inside the overview section you can press "Preview"
  • Add the URL of staging and connect.
  • Test in real-time the interaction.

Link to sample test page: https://foundation-s-tp1-1034-f-cqwzn8.herokuapp.com/en/
Related PRs/issues: #12696

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

┆Issue is synchronized with this Jira Story

@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-1034-f-cqwzn8 August 26, 2024 19:33 Inactive
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-1034-f-cqwzn8 August 26, 2024 20:47 Inactive
@dlopezvsr dlopezvsr marked this pull request as ready for review August 26, 2024 20:48
@dlopezvsr dlopezvsr self-assigned this Aug 26, 2024
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-1034-f-cqwzn8 August 26, 2024 22:18 Inactive
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dlopezvsr the PR looks good to me 👍 great job!

I was just wondering if there was a JIRA ticket that described why this change was needed, and if so, can we add it to this PR's description for more context?

Thanks!

@dlopezvsr
Copy link
Collaborator Author

Hi @danielfmiranda!

Thank you so much for your review 😄

Of course I just added another comment on the Jira ticket to keep context updated. I also tagged you for you to take a look when get a chance. Find the synced jira comments thread on the Related PRs/issues in the PR.

Let me know your comments.

@danielfmiranda danielfmiranda self-requested a review August 29, 2024 01:13
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the updated context @dlopezvsr!

After giving your PR a second look, everything looks good to me. Approved! 👍

@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-1034-f-cqwzn8 August 30, 2024 16:43 Inactive
@dlopezvsr dlopezvsr merged commit 6f40176 into main Aug 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants