-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace GTM ID #12739
Replace GTM ID #12739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dlopezvsr the PR looks good to me 👍 great job!
I was just wondering if there was a JIRA ticket that described why this change was needed, and if so, can we add it to this PR's description for more context?
Thanks!
Hi @danielfmiranda! Thank you so much for your review 😄 Of course I just added another comment on the Jira ticket to keep context updated. I also tagged you for you to take a look when get a chance. Find the synced jira comments thread on the Related PRs/issues in the PR. Let me know your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the updated context @dlopezvsr!
After giving your PR a second look, everything looks good to me. Approved! 👍
Description
This PR replaces the current GTM container ID for a new one, created with the purpose of correcting the actual differences in donation numbers between GA and Salesforce. Inside this GTM container a proper integration with Fundraise Up was implemented.
How to test
In case an access to GA for testing purposes is needed, will have to be requested.
In GTM:
Link to sample test page: https://foundation-s-tp1-1034-f-cqwzn8.herokuapp.com/en/
Related PRs/issues: #12696
Checklist
Tests
Changes in Models:
Documentation:
Merge Method
💡❗Remember to use squash merge when merging non-feature branches into
main
┆Issue is synchronized with this Jira Story