Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced emoji for special page nav link with text #12728

Merged
merged 9 commits into from
Aug 28, 2024

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Aug 21, 2024

Description

Replaced the use of emojis to indicate special pages on multipage menu with text note in red. I've created a few pages for demo purposes. Please see the screencaps below. Note that text in square brackets is part of the page's title.

Link to sample test page: https://foundation-s-tp1-126-10-9dwgzq.herokuapp.com/en/pr-test/
Related PRs/issues: #10148

Existing (Notice the use of emoji)

image

New

image

┆Issue is synchronized with this Jira Story

@mmmavis mmmavis temporarily deployed to foundation-s-tp1-126-10-9dwgzq August 22, 2024 00:02 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-tp1-126-10-9dwgzq August 23, 2024 20:09 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-tp1-126-10-9dwgzq August 26, 2024 17:50 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-tp1-126-10-9dwgzq August 26, 2024 22:36 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-tp1-126-10-9dwgzq August 26, 2024 23:19 Inactive
@mmmavis mmmavis marked this pull request as ready for review August 27, 2024 16:58
@mmmavis mmmavis temporarily deployed to foundation-s-tp1-126-10-9dwgzq August 27, 2024 16:59 Inactive
@mmmavis mmmavis requested a review from ramram-mf August 27, 2024 16:59
Copy link
Collaborator

@ramram-mf ramram-mf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i like emoji but this seems more like it. Thanks Mavis 🙏🏿.

@mmmavis mmmavis temporarily deployed to foundation-s-tp1-126-10-9dwgzq August 28, 2024 20:32 Inactive
@mmmavis mmmavis merged commit 2eef82e into main Aug 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants