Update BuyersGuideCallToAction with LinkBlock #12630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation through clean method
danielfmiranda
commented
Jul 23, 2024
danielfmiranda
commented
Jul 23, 2024
network-api/networkapi/wagtailpages/pagemodels/buyersguide/call_to_action.py
Show resolved
Hide resolved
danielfmiranda
commented
Jul 23, 2024
network-api/networkapi/wagtailpages/pagemodels/buyersguide/call_to_action.py
Show resolved
Hide resolved
danielfmiranda
commented
Aug 29, 2024
robdivincenzo
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related PRs/issues: TP1-833
This PR updates the
BuyersGuideCallToActionmodel by replacing thelink_label,link_target_page, andlink_target_urlfields, with a newlinkfield that uses theLinkBlockas a streamfield.Additionally, this PR includes the necessary migration files to introduce the new field, transfer existing data, and remove the old fields. HTML templates have also been updated to reflect this change, as well as the streamfield provider, and any wagtail hooks used to render the list view data in https://foundation.mozilla.org/cms/snippets/wagtailpages/buyersguidecalltoaction/.
Lastly, since we are no longer preforming custom validation for the old fields in the clean method, we removed the file that tested out that custom validation logic 👍 the validation is now all preformed within the linkblock, which already has a corresponding test file.
Screenshots
CMS (Before):
CMS list view (Before)
Frontend (Before):
CMS (After):
CMS List view (After):
Frontend (After):
┆Issue is synchronized with this Jira Story