Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Nav Fake Data Factory #12571

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Conversation

robdivincenzo
Copy link
Collaborator

@robdivincenzo robdivincenzo commented Jul 1, 2024

This PR has been reverted. Fixed version is in #12579


Description

This PR introduces a fake data factory for the main navigation.

The factory should mimic fairly closely as far as number and types of items. Like any fake data factory, there is a lot of fake generated links/pages/content, but some of the nav is real in order to more accurately capture the essence of the main nav on production. The factory is granular enough that we can specify any real content that might be helpful to have.

If there's anything specific you'd like to have linked within the factory instead of fake data, please let me know and I can adjust.

Link to sample test page: https://foundation-s-tp1-353-ma-liqlqz.herokuapp.com/
Related PRs/issues: TP-353 #12131

To Test

  1. Review the review app
  2. Note the autogenerated fake main navigation
  3. Check out this branch locally
  4. Run inv new-db to get a new database
  5. Note the autogenerated fake main navigation

┆Issue is synchronized with this Jira Story

@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-353-ma-vabhjd July 1, 2024 19:25 Inactive
@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-353-ma-liqlqz July 1, 2024 19:41 Inactive
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks @robdivincenzo 🙌

@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-353-ma-liqlqz July 2, 2024 12:39 Inactive
@robdivincenzo robdivincenzo merged commit c3c4209 into main Jul 2, 2024
6 checks passed
robdivincenzo added a commit that referenced this pull request Jul 3, 2024
robdivincenzo added a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants