Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change InlinePanel for MultipleChooserPanel #12514

Closed
wants to merge 1 commit into from

Conversation

AdalbertoMoz
Copy link
Contributor

@AdalbertoMoz AdalbertoMoz commented Jun 19, 2024

Description

This PR updates several Wagtail Panels from InlinePanel to MultipleChooserPanel, but only where feasible, as outlined in the original documentation.

Given that the 'Files changed' section might not fully capture the extent of these modifications, here is a list to assist testers in comparing the behavior between the Review App and other stable environments like Staging, ensuring the main functionality remains unaffected:

  • network-api/networkapi/nav/models.py
    • NavMenu:
      • Featured Blog Topics
  • network-api/networkapi/wagtailpages/pagemodels/app_install.py
    • AppInstallPage:
      • Donation Modal
  • network-api/networkapi/wagtailpages/pagemodels/base.py
    • InitiativesPage:
      • Highlights
    • ParticipatePage2:
      • Highlights Group 1
      • Highlights Group 2
    • Homepage:
      • Areas of focus
      • News you can use
      • Spotlight
  • network-api/networkapi/wagtailpages/pagemodels/blog/blog.py
    • BlogPage:
      • Author(s)
      • Related Blog Posts
  • network-api/networkapi/wagtailpages/pagemodels/blog/blog_index.py
    • BlogIndexPage:
      • Featured
  • network-api/networkapi/wagtailpages/pagemodels/buyersguide/article_page.py
    • BuyersGuideArticlePage:
      • Authors
      • Content categories
      • What to read next (related articles)
  • network-api/networkapi/wagtailpages/pagemodels/buyersguide/campaign_page.py
    • BuyersGuideCampaignPage:
      • Donation Modal
  • network-api/networkapi/wagtailpages/pagemodels/buyersguide/categories.py
    • BuyersGuideProductCategory:
      • Related articles
    • BuyersGuideCategoryNav:
      • Categories
  • network-api/networkapi/wagtailpages/pagemodels/buyersguide/editorial_content_index.py
    • BuyersGuideEditorialContentIndexPage:
      • Popular articles
  • network-api/networkapi/wagtailpages/pagemodels/buyersguide/homepage.py
    • BuyersGuidePage:
      • Supporting Pages
      • Popular articles
      • In the press
      • Excluded categories
  • network-api/networkapi/wagtailpages/pagemodels/buyersguide/products.py
    • ProductPage:
      • Product Category
      • News Links
      • Related Products
      • Related Articles
  • network-api/networkapi/wagtailpages/pagemodels/campaign_index.py
    • CampaignIndexPage:
      • Featured Pages
  • network-api/networkapi/wagtailpages/pagemodels/campaigns.py
    • CampaignPage:
      • Donation Modal
  • network-api/networkapi/wagtailpages/pagemodels/libraries/rcc/detail_page.py
    • RCCDetailPage:
      • Content types
      • Curricular areas
      • Topics
  • network-api/networkapi/wagtailpages/pagemodels/libraries/rcc/landing_page.py
    • RCCLandingPage:
      • Featured content types
      • Featured authors
  • network-api/networkapi/wagtailpages/pagemodels/libraries/research_hub/detail_page.py
    • ResearchDetailPage:
      • Topics
      • Regions
  • network-api/networkapi/wagtailpages/pagemodels/libraries/research_hub/landing_page.py
    • ResearchLandingPage:
      • Featured topics
      • Featured authors
  • network-api/networkapi/wagtailpages/pagemodels/publications/article.py
    • ArticlePage:
      • Author(s)
  • network-api/networkapi/wagtailpages/pagemodels/publications/publication.py
    • PublicationPage:
      • Author(s)

Link to sample test page: https://foundation-s-feature-12-t4lbf6.herokuapp.com/en/
Related PRs/issues: #12421

Checklist

Tests
- [ ] Is the code I'm adding covered by tests?

Changes in Models:
- [ ] Did I update or add new fake data?
- [ ] Did I squash my migration?
- [ ] Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:
- [ ] Is my code documented?
- [ ] Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

┆Issue is synchronized with this Jira Story

@AdalbertoMoz AdalbertoMoz temporarily deployed to foundation-s-feature-12-t4lbf6 June 19, 2024 22:38 Inactive
@AdalbertoMoz AdalbertoMoz force-pushed the feature/12421-using-MultipleChooserPanel branch from 67cc259 to fcb85e5 Compare June 21, 2024 16:14
@AdalbertoMoz AdalbertoMoz temporarily deployed to foundation-s-feature-12-t4lbf6 June 21, 2024 16:14 Inactive
@AdalbertoMoz AdalbertoMoz self-assigned this Jun 21, 2024
@danielfmiranda danielfmiranda removed their request for review June 27, 2024 22:18
@mofodevops mofodevops closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants