Feature/TP1-569: Add Invoke command to copy Staging DB to a specific Review App #12493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdalbertoMoz
force-pushed
the
feature/TP1-569
branch
from
120beff to
0403724
Compare
AdalbertoMoz
changed the title
AdalbertoMoz
force-pushed
the
feature/TP1-569
branch
from
0403724 to
d28dec2
Compare
robdivincenzo
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
LGTM and works well @AdalbertoMoz! Left one small comment on documenting before merging in. Thanks!
danielfmiranda
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Amazing work @AdalbertoMoz! Thanks very much for taking this on, I know its going to be very helpful to the team in the future 👍 Approved!
|
➤ Simon Acosta Torres commented: PR merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This script is a refined and Python-rewritten version of the one used in the Mofo Cron Repository, with minor changes.
New Command:
I have introduced a new
invokecommand:invoke staging-to-review-app <review_app_name>. This command allows you to copy the Staging Database to the Review Apps.Benefits of Using the Staging Database
1. Shared S3 Bucket:
Staging shares the same S3 bucket as the Review Apps. This ensures that all S3 assets are displayed correctly, preventing any loss of static files on the pages.
2. Recent Data:
Staging is synced with the Production Database every Monday. Therefore, the data copied to our Review App is always recent and up-to-date.
FAQ
- Is the issue with Review Apps redirecting to Staging resolved?
Yes, this issue is resolved. The cleanup.sql file now includes changes that automatically update the domain and hostnames within the Review App Databases for both Foundation and Mozfest sites.
- Do I need any prerequisites installed to execute the script?
Yes, you need to have the Heroku CLI and psql installed on your local machine. The script will check for these prerequisites and will not start if they are not installed.
Link to sample test page: https://foundation-s-feature-tp-id5474.herokuapp.com/
Related PRs/issues: #12255
Checklist
Pending Steps
Tests- [ ] Is the code I'm adding covered by tests?Changes in Models:- [ ] Did I update or add new fake data?- [ ] Did I squash my migration?- [ ] Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?Documentation:- [ ] Is my code documented?- [ ] Did I update the READMEs or wagtail documentation?Merge Method
💡❗Remember to use squash merge when merging non-feature branches into
main┆Issue is synchronized with this Jira Story