Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all zen_mode references from page models and templates #12492

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

ramram-mf
Copy link
Collaborator

@ramram-mf ramram-mf commented Jun 17, 2024

Description

⚠️ Please disable preboot for the deployment of this feature! ⚠️

This PR removes all the zen_mode references from all the models, which includes the field deletion on:

  • PrimaryPage
  • ModularPage

Includes a new migration reflecting those updates and the template updates that referenced zen_mode.

To Test

Log in to the cms here (with admin2:admin2 credentials) and create a new article page, you will not find the zen_mode field anymore.

Link to sample test page:
Related PRs/issues: #12321

┆Issue is synchronized with this Jira Story

@ramram-mf ramram-mf changed the title Remove all zen_mode references from page models Remove all zen_mode references from page models and templates Jun 17, 2024
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-653-re-uymjxn June 17, 2024 22:28 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-653-re-xouthm June 18, 2024 02:51 Inactive
@ramram-mf ramram-mf requested a review from danielfmiranda June 18, 2024 17:50
@ramram-mf ramram-mf marked this pull request as ready for review June 18, 2024 17:50
@ramram-mf ramram-mf self-assigned this Jun 18, 2024
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @ramram-mf! Thank you very much. LGTM 🚀

@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-653-re-xouthm June 18, 2024 23:47 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-653-re-xouthm June 20, 2024 17:01 Inactive
@ramram-mf ramram-mf merged commit 8e507f0 into main Jun 20, 2024
6 checks passed
@data-sync-user
Copy link
Collaborator

➤ Simon Acosta Torres commented:

PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants