Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize related blog topics #12483

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

robdivincenzo
Copy link
Collaborator

@robdivincenzo robdivincenzo commented Jun 14, 2024

Description

This PR will ensure that the routes are building from the parent_or_root of the active locale

Link to sample test page: https://foundation-s-tp1-770-12-bkm9ye.mofostaging.net/en/blog/dating-app-user-privacy/
Related PRs/issues: TP1-770 #12445

To Test

  1. Review the test page
  2. Verify Blog Topic links in the Related content section are linking to the en localized blog topic pages
  3. Switch /en/ locale to /fr/
  4. Verify the Blog Topic links in the Related content section are linking to the fr localized blog topic pages

┆Issue is synchronized with this Jira Story

Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks for providing some easy-to-follow instructions for testing @robdivincenzo 🙌 After testing and looking at the code changes, everything is looking good to me!

Approved 🚀

@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-770-12-bkm9ye June 25, 2024 12:02 Inactive
@robdivincenzo robdivincenzo merged commit f5e025c into main Jun 25, 2024
6 checks passed
robdivincenzo added a commit that referenced this pull request Jun 25, 2024
robdivincenzo added a commit that referenced this pull request Jun 25, 2024
robdivincenzo added a commit that referenced this pull request Jun 25, 2024
@data-sync-user
Copy link
Collaborator

➤ Simon Acosta Torres commented:

PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants