-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize related blog topics #12483
Merged
robdivincenzo
merged 3 commits into
main
from
tp1-770-12445-localize-related-blog-topics
Jun 25, 2024
Merged
Localize related blog topics #12483
robdivincenzo
merged 3 commits into
main
from
tp1-770-12445-localize-related-blog-topics
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfmiranda
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! Thanks for providing some easy-to-follow instructions for testing @robdivincenzo 🙌 After testing and looking at the code changes, everything is looking good to me!
Approved 🚀
robdivincenzo
added a commit
that referenced
this pull request
Jun 25, 2024
This reverts commit f5e025c.
robdivincenzo
added a commit
that referenced
this pull request
Jun 25, 2024
robdivincenzo
added a commit
that referenced
this pull request
Jun 25, 2024
➤ Simon Acosta Torres commented: PR merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will ensure that the routes are building from the
parent_or_root
of the active localeLink to sample test page: https://foundation-s-tp1-770-12-bkm9ye.mofostaging.net/en/blog/dating-app-user-privacy/
Related PRs/issues: TP1-770 #12445
To Test
Related content
section are linking to theen
localized blog topic pages/en/
locale to/fr/
Related content
section are linking to thefr
localized blog topic pages┆Issue is synchronized with this Jira Story