Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zen mode references from primary-nav.js and primary_nav.html #12482

Closed

Conversation

ramram-mf
Copy link
Collaborator

@ramram-mf ramram-mf commented Jun 13, 2024

Description

This PR removes all references to zen mode and its conditional tags and classnames from primary-nav.js and primary_nav.html.

Link to sample test page: https://foundation-s-tp1-652-ad-vdztju.herokuapp.com/en/
Related PRs/issues: #12321

┆Issue is synchronized with this Jira Story

@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-652-ad-vdztju June 13, 2024 03:23 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-652-ad-vdztju June 13, 2024 03:36 Inactive
@ramram-mf ramram-mf requested a review from robdivincenzo June 13, 2024 16:28
@robdivincenzo
Copy link
Collaborator

Hey @ramram-mf, saw a notification for review. Double-checking if this is still a draft or is it ready for review?

@ramram-mf ramram-mf closed this Jun 18, 2024
@ramram-mf ramram-mf removed the request for review from robdivincenzo June 18, 2024 18:00
@ramram-mf
Copy link
Collaborator Author

Hey @ramram-mf, saw a notification for review. Double-checking if this is still a draft or is it ready for review?

Closed as duplicate since Daniel recommended to consolidate all template and model updates into a single PR.

@data-sync-user
Copy link
Collaborator

➤ Simon Acosta Torres commented:

PR closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants