-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AnnotatedImageBlock to use LinkBlock #12481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…single migration files
danielfmiranda
commented
Jun 14, 2024
network-api/networkapi/donate/migrations/0012_update_annotatedimageblock_with_linkblock.py
Outdated
Show resolved
Hide resolved
danielfmiranda
commented
Jun 14, 2024
robdivincenzo
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @danielfmiranda! Thanks for taking point on this first PR for the epic
danielfmiranda
added
run visual regression tests
and removed
run visual regression tests
labels
Jun 20, 2024
danielfmiranda
added a commit
that referenced
this pull request
Jun 21, 2024
This reverts commit a3ec651.
This was referenced Jun 21, 2024
danielfmiranda
added a commit
that referenced
this pull request
Jun 21, 2024
➤ Simon Acosta Torres commented: PR merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related PRs/issues: #12480, TP1-804
This PR implements the following changes:
LinkWithoutLabelBlock
: Derived fromLinkBlock
, it omits the requiredlabel
field, allowing usage where a label is not necessary, such as inAnnotatedImageBlock
where the "caption" serves as the label.captionURL
charField Replacement: Replaces thecaptionURL
char field withcaption_url
usingLinkWithoutLabelBlock
, wrapped in aListBlock
to make it optional.annotated_image_block.html
template to account for the new field.AnnotatedImageBlock
to include a link value when created via the streamfield provider.caption_url
field, migrates existing data, and deletes the oldcaptionURL
field.test_block_type_report.py
to accommodate the newLinkWithoutLabelBlock
field.┆Issue is synchronized with this Jira Story
Screenshots
Before (with CharBlock):
After (with LinkWithoutLabelBlock):