Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add english language code to the x-default link attribute #12479

Merged

Conversation

ramram-mf
Copy link
Collaborator

@ramram-mf ramram-mf commented Jun 13, 2024

Description

This PR modifies the x-default alternate link tag from the site, adding the en language code to the url so SEO improves by reducing redirects following that metadata.

image

To Test

Open any page of the site, right click on any part of the body and select View Source from the context menu, updated metadata is located at line 182 inside the headtag.

Link to sample test page: https://foundation-s-tp1-332-hr-cs8gft.herokuapp.com/en/
Related PRs/issues: #8834

┆Issue is synchronized with this Jira Story

@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-332-hr-cs8gft June 13, 2024 01:33 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-tp1-332-hr-8nppvq June 13, 2024 01:35 Inactive
@ramram-mf ramram-mf requested a review from danielfmiranda June 13, 2024 01:55
@ramram-mf ramram-mf marked this pull request as ready for review June 13, 2024 01:55
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Excellent work. Thanks @ramram-mf. 🙌

Approved!

@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-332-hr-8nppvq June 13, 2024 20:05 Inactive
@ramram-mf ramram-mf merged commit d066a7c into main Jun 13, 2024
6 checks passed
@data-sync-user
Copy link
Collaborator

➤ Simon Acosta Torres commented:

PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants