Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNI and Redis cache optimization #12470

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Conversation

robdivincenzo
Copy link
Collaborator

@robdivincenzo robdivincenzo commented Jun 10, 2024

Description

This PR will remove memory-intensive custom template caching mechanisms from PNI (opting for standard PostgreSQL calls / rendition cache / Cloudflare caching instead) to free up Redis memory cache and correct "Out of Memory" errors.

Link to sample test page: https://foundation-s-tp1-557-12-r8pzre.herokuapp.com/en/privacynotincluded/
Related PRs/issues: #12243

To Test:

  1. Navigate to review app page
  2. Navigate through the PNI homepage and category pages to ensure everything still loads correctly and without error

┆Issue is synchronized with this Jira Story

@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-557-12-r8pzre June 10, 2024 18:51 Inactive
@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-557-12-r8pzre June 10, 2024 19:17 Inactive
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robdivincenzo! Looking forward to having less "out of memory" errors. LGTM! 🚀

@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-557-12-r8pzre June 11, 2024 13:57 Inactive
@robdivincenzo robdivincenzo merged commit da43e3a into main Jun 11, 2024
6 checks passed
@data-sync-user
Copy link
Collaborator

➤ Simon Acosta Torres commented:

PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants