Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created factory for donate's "Ways to give" page and added it to Percy tests #12297

Merged
merged 5 commits into from
May 8, 2024

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented May 3, 2024

Description

Link to sample test page: https://foundation-s-tp1-216-wa-gxvu6s.herokuapp.com/en/donate/ways-to-give/
Related PRs/issues: #11497, https://mozilla-hub.atlassian.net/browse/TP1-216

This PR creates a new factory for the Donate subsite's "ways to give" page. It also adds the route donate/ways-to-give/ to the list of pages tested by Percy, so we can test for any visual regressions in the future.

┆Issue is synchronized with this Jira Story

@danielfmiranda danielfmiranda changed the title Tp1 216 ways to give factory Created factory for donate's "Ways to give" page and added it to Percy tests May 3, 2024
@danielfmiranda danielfmiranda marked this pull request as ready for review May 3, 2024 21:39
@danielfmiranda danielfmiranda temporarily deployed to foundation-s-tp1-216-wa-gxvu6s May 3, 2024 21:40 Inactive
@danielfmiranda danielfmiranda temporarily deployed to foundation-s-tp1-216-wa-gxvu6s May 3, 2024 21:58 Inactive
Copy link
Collaborator

@robdivincenzo robdivincenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielfmiranda danielfmiranda temporarily deployed to foundation-s-tp1-216-wa-gxvu6s May 7, 2024 22:23 Inactive
@danielfmiranda danielfmiranda temporarily deployed to foundation-s-tp1-216-wa-gxvu6s May 8, 2024 00:21 Inactive
@danielfmiranda danielfmiranda merged commit 1132a53 into main May 8, 2024
6 checks passed
@data-sync-user
Copy link
Collaborator

➤ Simon Acosta Torres commented:

PR has already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants