Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed class that was causing visual regression on campaign page navs #12291

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Apr 30, 2024

Description

Link to sample test page:
Related PRs/issues: #12290

This PR removes a tailwind class that seemed to be causing a visual regression on the campaign page navigation bar

Screenshots:

Homepage (unnaffected):
Screenshot 2024-04-30 at 14-30-57 Mozilla Foundation

Campaign Page with Zen Mode:
Screenshot 2024-04-30 at 14-29-50 Demand Privacy for All Support a U S  Data Privacy Law

Campaign Page without Zen Mode:
Screenshot 2024-04-30 at 14-30-09 Demand Privacy for All Support a U S  Data Privacy Law

┆Issue is synchronized with this Jira Story

Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching & fixing this, @danielfmiranda !

@mmmavis mmmavis merged commit 2ea555c into main Apr 30, 2024
6 checks passed
@data-sync-user
Copy link
Collaborator

➤ Simon Acosta Torres commented:

PR has already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants