[Mobile Nav] Added sliding effect and allowed multiple open accordions #12260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmmavis
changed the title
jhonatan-lopes
force-pushed
the
feature-branch/main-nav-dropdown
branch
from
ec8775d to
9128e57
Compare
mmmavis
force-pushed
the
feature/main-nav/animation
branch
from
a907754 to
409d914
Compare
mmmavis
force-pushed
the
feature/main-nav/animation
branch
from
402621d to
45762ae
Compare
sabrinang
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Desktop
- When moving from one item to another, I think there is a quick fade/ease out that makes it look like there's a bit of background flashing through going on (this could be simplified)
Tablet
- Line below navigation disappears after opening item like “who we are” or after when other items snap to top
- Border reappears when closing but items do not reset so top item (so “who we are” gets hidden) appears fully hidden
- The snap to top is working inconsistently for me, but mainly “Blog” moves up a bit more all the time while the others often stay in place which makes it feel inconsistent/unpredictable
Mobile
- When closing a section other than the first section, a strip is seen of “who we are” but does not fully reset back to the top
I’m thinking overall, having close/open animation without snap to top would provide a more predictable/consistent experience
|
Mobile
|
|
The tablet/mobile issues resolved with removing the snap to top combo. Wanted to check in on desktop, if it was possible to not have the background flashing through when transitioning from one primary nav item to another? Video comparing PR to figma mockup to demonstrate what I mean: |
mmmavis
force-pushed
the
feature/main-nav/animation
branch
from
557c3af to
432b499
Compare
mmmavis
commented
May 1, 2024
mmmavis
commented
May 1, 2024
nancyt1
approved these changes
May 1, 2024
sabrinang
approved these changes
May 1, 2024
mmmavis
changed the title
mmmavis
commented
May 1, 2024
robdivincenzo
approved these changes
May 2, 2024
|
➤ Simon Acosta Torres commented: PR has already been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to review app: https://foundation-s-feature-ma-36qyhj.herokuapp.com/en/ (CMS cred:
admin2/admin2password)Related PRs/issues: #12233
┆Issue is synchronized with this Jira Story