[Main nav] Navigation column [TP-266] #12047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhonatan-lopes
changed the base branch from
main
to
feature-branch/main-nav-dropdown
| class NavColumn(blocks.StructBlock): | ||
| title = blocks.CharBlock(max_length=100) | ||
| links = blocks.ListBlock(NavItem, min_num=1, max_num=4) | ||
| button = blocks.ListBlock(NavButton, required=False, min_num=0, max_num=1) |
There was a problem hiding this comment.
Hey @jhonatan-lopes, is this dev pattern of encompassing a block w/ max_num=1 in a ListBlock useful for:
- Cleaner UI by hiding fields if child block not used
- Additional control by not requiring the child block itself (and then requiring the child block fields if it's been added)
- Anything else I'm missing?
There was a problem hiding this comment.
Hey @robdivincenzo, this is documented here: https://docs.wagtail.org/en/stable/topics/streamfield.html#limiting-block-counts
Basically, we can use min_num and max_num to limit the number of blocks in a ListBlock or StreamBlock combination. In this case, we need at least one link and at most 4. Button, on the other hand, is optional, so we use the ListBlock with min_num=0 and max_num=1.
robdivincenzo
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
LGTM @jhonatan-lopes, great work! One comment, but not a change request
jhonatan-lopes
merged commit a96ddfa
into
feature-branch/main-nav-dropdown
8 checks passed
jhonatan-lopes
added a commit
that referenced
this pull request
Mar 28, 2024
* Add description to NavLinkBlock * Rename NavLinkBlock to NavItem * Add NavButtonBlock * Fix test name * Add a NavColumn model
jhonatan-lopes
added a commit
that referenced
this pull request
Apr 3, 2024
* Add description to NavLinkBlock * Rename NavLinkBlock to NavItem * Add NavButtonBlock * Fix test name * Add a NavColumn model
jhonatan-lopes
added a commit
that referenced
this pull request
Apr 4, 2024
* Add description to NavLinkBlock * Rename NavLinkBlock to NavItem * Add NavButtonBlock * Fix test name * Add a NavColumn model
jhonatan-lopes
added a commit
that referenced
this pull request
Apr 18, 2024
* Add description to NavLinkBlock * Rename NavLinkBlock to NavItem * Add NavButtonBlock * Fix test name * Add a NavColumn model
jhonatan-lopes
added a commit
that referenced
this pull request
Apr 29, 2024
* Add description to NavLinkBlock * Rename NavLinkBlock to NavItem * Add NavButtonBlock * Fix test name * Add a NavColumn model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a
NavColumnandNavButtonblocks.Link to sample test page:
Related PRs/issues:
Checklist
Tests
Changes in Models:
[ ] Did I squash my migration?[ ] Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?Documentation:
[ ] Did I update the READMEs or wagtail documentation?Merge Method
💡❗Remember to use squash merge when merging non-feature branches into
main┆Issue is synchronized with this Jira Story