Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup wagtail-ab-testing tracking script #11889

Merged
merged 6 commits into from
Feb 20, 2024

Conversation

jhonatan-lopes
Copy link
Contributor

@jhonatan-lopes jhonatan-lopes commented Feb 19, 2024

Description

Setup the tracking script for wagtail-ab-testing to be compatible with our CSP.

Link to sample test page:

Related PRs/issues: #11890

Testing

  1. Go to "A/B test stats" page and note the number of participants in each group (control vs variant)
  2. Go to the "A/B test page" and note if it is a control or variant (the variant's title starts with "[A/B test]")
  3. At the "A/B test stats" page, check that the sample size increased by 1 but the number of conversions in your test (control or variant) was kept constant
  4. Go to the "Goal page" to register a conversion
  5. Go back to the "A/B test stats" page and check that now the number of conversions in your test group (control or variant) has increased by one

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

@jhonatan-lopes jhonatan-lopes temporarily deployed to foundation-s-feature-fi-ks2aui February 19, 2024 17:42 Inactive
@jhonatan-lopes jhonatan-lopes temporarily deployed to foundation-s-feature-fi-ks2aui February 19, 2024 18:50 Inactive
@jhonatan-lopes jhonatan-lopes requested review from danielfmiranda and robdivincenzo and removed request for robdivincenzo and danielfmiranda February 19, 2024 19:08
@jhonatan-lopes jhonatan-lopes marked this pull request as draft February 20, 2024 13:32
@jhonatan-lopes jhonatan-lopes marked this pull request as ready for review February 20, 2024 17:37
Copy link
Collaborator

@robdivincenzo robdivincenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jhonatan-lopes !

@robdivincenzo
Copy link
Collaborator

@jhonatan-lopes Not related to this pull request, but as a follow-up, there are concerns with the dashboard's visibility on the dark theme. Are we tracking that issue somewhere?

@jhonatan-lopes
Copy link
Contributor Author

Hey @robdivincenzo, thanks for flagging that up! It's being tracked on wagtail-nest/wagtail-ab-testing#62, and I'm working on it!

@jhonatan-lopes jhonatan-lopes merged commit 4abf839 into main Feb 20, 2024
6 checks passed
@jhonatan-lopes jhonatan-lopes deleted the feature/fix-ab-testing-script branch February 20, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants