Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - HTML validation errors on primary pages #11868

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

Morsey187
Copy link
Contributor

Description

Link to sample test page: https://foundation.mozilla.org/en/who-we-are/
Related PRs/issues: #11645

Fixes HTML validation errors.
Note the other html validation related PRs solve the majority of the issues for this page so this PR is pretty light, I've noted an issue in a thread which will need to be resolved on production by an editor however.

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

@Morsey187
Copy link
Contributor Author

Validator flagged this odd error .</span class="body-large"> on the who-we-are page.

Screenshots

Markup

Screenshot 2024-02-14 at 08 15 25

Paragraph within the editor

Screenshot 2024-02-14 at 08 06 19

I couldn't find an issue related to the code investigating this, however I was able to solve it locally by simply reformating the richtext field.
My best guess would be that a user pasted HTML markup directly into the field panel when writing the content for this page, which likely resulted in some formating issues.
I’d recommend someone with access the the wagtail admin on production to should delete the paragraph spacing between

“In the early 2000s, the Mozilla community built Firefox. We toppled the browser monopoly, gave users choice and control online, and helped create a healthier internet.”

and

“Twenty years later, Mozilla continues to fight for a healthy internet — one where Big Tech is held accountable and individual users have real agency
online.”

then apply a new line and republish the page.

@mmmavis
Copy link
Collaborator

mmmavis commented Feb 16, 2024

@Morsey187 thanks for the suggestion on going into the CMS to fix the validation error. I went ahead to make the edit and now the issue is gone!

@mmmavis mmmavis merged commit 3eca2da into main Feb 16, 2024
6 checks passed
@mmmavis mmmavis deleted the fix/11645-HTML-validation-errors-primary-page branch February 16, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants