Fix - Refactor attribute id to data selector to fix duplicate ids #11866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to sample test page: https://foundation.mozilla.org/en/privacynotincluded/
Related PRs/issues: #11605
Swaps use of ID attributes for data attributes on the donate button to allow multiple instances to fix html validation errors of Duplicate IDs. can test localhost:8000/en/privacynotincluded/ with a nu html validator to verify.
Note: This also fixes a bug I noticed where donation button clicks were only being tracked for mobile (i.e. no clicks on the donation button in the desktop navigation bar are currently being tracked) as the querySelector in
header-donate-button.js
queries for one element. This might be worth forwarding to someone in your SEO team to make sure it doesn’t skew or cause confusion with any active tracking, campaigns etc.Checklist
Tests
Changes in Models:
Documentation:
Merge Method
💡❗Remember to use squash merge when merging non-feature branches into
main
┆Issue is synchronized with this Jira Story