Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Remove trailing slash from void elements #11863

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

Morsey187
Copy link
Contributor

Description

Link to sample test page: This effects most if not all pages.
Related PRs/issues: #11592

There are quite a few changes accross multiple pages/tempaltes, although confident the changes themselves (removed trailing slash) won't effect them.

Note:

  • I'm not touching React's closing tags as they're not part of SSR and those tags are rendered by React correctly (without trailing slashes) anyway the JSX syntax is just a bit different.
  • There are some tags I have missed (such as hr elements) however I'm fairly confident I've addressed those in other PRs I'm about to open.

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

@Morsey187 Morsey187 requested a review from mmmavis February 14, 2024 18:09
@Morsey187 Morsey187 changed the title Fix - Remove trailing slash from void elements #11592 Fix - Remove trailing slash from void elements Feb 14, 2024
Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Thank you for taking the time to address these issues.

@mmmavis mmmavis merged commit 087d391 into main Feb 20, 2024
6 checks passed
@mmmavis mmmavis deleted the fix/11592-remove-trailing-slash-from-void-elements branch February 20, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants