Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prettier from 2.8.8 to 3.2.5 #11820

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 5, 2024

Bumps prettier from 2.8.8 to 3.2.5.

Release notes

Sourced from prettier's releases.

3.2.5

🔗 Changelog

3.2.4

  • Fix .eslintrc.json format #15947

🔗 Changelog

3.2.3

  • Format tsconfig.json file with jsonc parser #15927

🔗 Changelog

3.2.2

🔗 Changelog

3.2.1

🔗 Changelog

3.2.0

diff

🔗 Release note

3.1.1

🔗 Changelog

3.1.0

diff

🔗 Release note

3.0.3

🔗 Changelog

3.0.2

🔗 Changelog

3.0.1

🔗 Changelog

3.0.0

diff

🔗 Release note

3.0.0-alpha.6

What's Changed

... (truncated)

Changelog

Sourced from prettier's changelog.

3.2.5

diff

Support Angular inline styles as single template literal (#15968 by @​sosukesuzuki)

Angular v17 supports single string inline styles.

// Input
@Component({
  template: `<div>...</div>`,
  styles: `h1 { color: blue; }`,
})
export class AppComponent {}
// Prettier 3.2.4
@​Component({
template: &lt;div&gt;...&lt;/div&gt;,
styles: h1 { color: blue; },
})
export class AppComponent {}
// Prettier 3.2.5
@​Component({
template: &lt;div&gt;...&lt;/div&gt;,
styles: h1 { color: blue; },
})
export class AppComponent {}

Unexpected embedded formatting for Angular template (#15969 by @​JounQin)

Computed template should not be considered as Angular component template

// Input
const template = "foobar";
@​Component({
[template]: &lt;h1&gt;{{       hello }}&lt;/h1&gt;,
})
export class AppComponent {}
</tr></table>

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

┆Issue is synchronized with this Jira Story

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file engineering labels Feb 5, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/prettier-3.2.5 branch 8 times, most recently from 5ffb46f to 8e40478 Compare March 5, 2024 17:44
@mmmavis mmmavis self-requested a review March 12, 2024 22:19
@mmmavis mmmavis self-assigned this Mar 12, 2024
@mmmavis
Copy link
Collaborator

mmmavis commented Mar 13, 2024

eslint-plugin-prettier and stylelint-prettier modules will need to be updated before we can bump prettier version to 3.2.5. This is due to prettier.resolveConfig.sync getting deprecated in v3. (See our integration errors and Prettier v3 CHANGELOG)

@mmmavis
Copy link
Collaborator

mmmavis commented Mar 13, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/prettier-3.2.5 branch from 8e40478 to b81e287 Compare March 13, 2024 17:59
@mmmavis
Copy link
Collaborator

mmmavis commented Mar 18, 2024

@dependabot rebase

Bumps [prettier](https://github.com/prettier/prettier) from 2.8.8 to 3.2.5.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.8...3.2.5)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/prettier-3.2.5 branch from b81e287 to 1ce69c1 Compare March 18, 2024 19:29
…tween prettier v3 and eslint-plugin-prettier v4
@mmmavis
Copy link
Collaborator

mmmavis commented Mar 21, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 21, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@mmmavis
Copy link
Collaborator

mmmavis commented Mar 21, 2024

I'm gonna close this PR and manually create one to update prettier, eslint-plugin-prettier and stylelint-prettier all at the same time to resolve the version incompatibility issues between these packages.

@mmmavis mmmavis closed this Mar 21, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 21, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/prettier-3.2.5 branch March 21, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant