Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced newsletter signup form in PNI product creep vote section with the new implementation approach #11791

Merged
merged 10 commits into from
Feb 6, 2024

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Jan 30, 2024

Replaced newsletter signup form in PNI product creep vote section with the new implementation approach.

Related to #11787

image

To test

  1. Go to any PNI product page on review app. e.g., https://foundation-s-11787-pni--jl3fjv.herokuapp.com/en/privacynotincluded/green-above-meeting-lay-blue/
  2. Go to the voting section (titled "How creepy do you think this is?") to vote
  3. The newsletter signup screen shows up only on the 2nd or 3rd time you voted on the same product page. If you wanna use the same product page to test, a way to hack it is to change sessionStorag's voteCount to 2. i.e., run sessionStorage.setItem("voteCount", 2) on console, refresh the page, and vote again
  4. Test to see if newsletter signup can go through and if the "No thanks" button works as expected.

@mmmavis mmmavis temporarily deployed to foundation-s-11787-pni--jl3fjv February 1, 2024 17:02 Inactive
@mmmavis mmmavis marked this pull request as ready for review February 1, 2024 17:57
@mmmavis mmmavis changed the title [WIP] Replaced newsletter signup form in PNI product creep vote section with the new implementation approach Replaced newsletter signup form in PNI product creep vote section with the new implementation approach Feb 1, 2024
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks @mmmavis

@mmmavis mmmavis merged commit 4b46b83 into main Feb 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants