Update MozFest newsletter signup modules #11786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ground_block.html
…e is added to submit button
mmmavis
commented
Jan 30, 2024
network-api/networkapi/mozfest/templates/fragments/blocks/sign_up_block.html
Show resolved
Hide resolved
mmmavis
commented
Jan 30, 2024
network-api/networkapi/wagtailpages/templates/wagtailpages/blocks/newsletter_signup_block.html
Outdated
Show resolved
Hide resolved
mmmavis
changed the title
danielfmiranda
temporarily deployed
to
foundation-s-mozfest-ne-ivbqtl
danielfmiranda
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Hi @mmmavis!
Thanks again for always leaving detailed descriptions, updates, and comments in your PRs. They help greatly, especially in PRs such as this where it could have been confusing to see two sets of newsletter blocks for mozfest.
I have tested this PR on my local machine, and was also able to get a "newsletter signup with background" on a review app here
Everythings looking good to me! Approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11672
join.jsxI didn't set up a review app for this PR as some parts can only be tested locally (on a Mozfest landing page, for example). Please see inline comments for details.