[PNI] Handle 100 average creepiness #11538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmmavis
requested changes
Dec 13, 2023
network-api/networkapi/wagtailpages/tests/buyersguide/test_product_page_evaluation.py
Show resolved
Hide resolved
mmmavis
approved these changes
Jan 11, 2024
network-api/networkapi/wagtailpages/tests/buyersguide/test_product_page_evaluation.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where products with 100 average creepiness would have a
KeyErrorwhen trying to get theaverage_binproperty.Link to sample test page:
Related PRs/issues: #
Checklist
Tests
Changes in Models:
[ ] Did I update or add new fake data?[ ] Did I squash my migration?[ ] Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?Documentation:
[ ] Is my code documented?[ ] Did I update the READMEs or wagtail documentation?Merge Method
💡❗Remember to use squash merge when merging non-feature branches into
main