Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MozFest - 2708 Hero #11515

Merged
merged 6 commits into from
Dec 11, 2023
Merged

MozFest - 2708 Hero #11515

merged 6 commits into from
Dec 11, 2023

Conversation

chris-lawton
Copy link
Collaborator

Description

  • Adds the updated hero styles which will be used on the hero and landing page
  • Adds a skeleton MozFest landing page

Data is currently hardcoded but will be replaced by BE

Desktop/Tablet/Mobile screens

Screenshot 2023-12-08 at 16 18 05

Screenshot 2023-12-08 at 16 16 29

Screenshot 2023-12-08 at 16 16 49

Link to sample test page: http://mozfest.localhost:8000/en/
Related PRs/issues: #

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

@chris-lawton chris-lawton requested a review from tbrlpld December 8, 2023 16:19
Copy link
Collaborator

@tbrlpld tbrlpld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chris-lawton. Left some non-blocking questions.

Also noticed on the screenshots that the content below the header bumps right onto the image. Is that meant to be that way?

@chris-lawton
Copy link
Collaborator Author

Thanks @chris-lawton. Left some non-blocking questions.

Also noticed on the screenshots that the content below the header bumps right onto the image. Is that meant to be that way?

Thanks @tbrlpld - The spacing under the hero differs on the landing page and homepage so i'll handle it in future components.

@chris-lawton chris-lawton merged commit 202a79c into integration/mozfest-2024 Dec 11, 2023
5 checks passed
@chris-lawton chris-lawton deleted the feature/2708-hero branch December 11, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants