Fix - HTML validation errors banner page (#11874)

* Refactor dropwdown link for accessibility * Fix valdiation errors * Revert "Refactor dropwdown link for accessibility" This reverts commit 8d8db5b. * Lint manually --------- Co-authored-by: Ben Morse <[email protected]> Co-authored-by: Mavis Ou <[email protected]>
MozillaFoundation · Feb 28, 2024 · e8de847 · e8de847
1 parent a1e19da
commit e8de847
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 12 deletions.
diff --git a/network-api/networkapi/mozfest/templates/fragments/hero/featured_video.html b/network-api/networkapi/mozfest/templates/fragments/hero/featured_video.html
@@ -38,7 +38,6 @@
                 {% if block.block_type == 'external_video' %}
                     <iframe
                         src=""
-                        frameborder="0"
                         class="embed-responsive-item"
                         allow="autoplay; encrypted-media"
                         allowfullscreen>

diff --git a/network-api/networkapi/mozfest/templates/fragments/video.html b/network-api/networkapi/mozfest/templates/fragments/video.html
@@ -32,7 +32,7 @@
     </button>
 
     {# Video #}
-    <iframe src="" frameborder="0" class="embed-responsive-item" allow="autoplay; encrypted-media" allowfullscreen></iframe>
+    <iframe src="" class="embed-responsive-item" allow="autoplay; encrypted-media" allowfullscreen></iframe>
 </div>
 
 <h2 class="tw-h3-heading tw-mt-8">{{ video.title }}</h2>

diff --git a/network-api/networkapi/wagtailpages/templates/wagtailpages/blocks/airtable_block.html b/network-api/networkapi/wagtailpages/templates/wagtailpages/blocks/airtable_block.html
@@ -3,6 +3,6 @@
 
 {% block block_content %}
     <script async defer src="https://static.airtable.com/js/embed/embed_snippet_v1.js"></script><iframe
-        class="airtable-embed mb-4 airtable-dynamic-height" src="{{ value.url }}" frameborder="0" width="100%"
+        class="airtable-embed mb-4 airtable-dynamic-height" src="{{ value.url }}" width="100%"
         height="{{ value.height|unlocalize }}"></iframe>
 {% endblock %}
diff --git a/network-api/networkapi/wagtailpages/templates/wagtailpages/blocks/video_block.html b/network-api/networkapi/wagtailpages/templates/wagtailpages/blocks/video_block.html
@@ -22,7 +22,6 @@
         <div class="embed-responsive embed-responsive-16by9 print:tw-hidden" {% if 'player.vimeo.com' in value.url and value.video_width == "full_width" %}style="padding: 56.25% 0 0 0;"{% endif %}>
             <iframe
                 src="{{ value.url }}"
-                frameborder="0"
                 class="embed-responsive-item"
                 allow="autoplay; encrypted-media"
                 allowfullscreen>

diff --git a/network-api/networkapi/wagtailpages/templates/wagtailpages/mini_site_name_space.html b/network-api/networkapi/wagtailpages/templates/wagtailpages/mini_site_name_space.html
@@ -6,13 +6,15 @@
     {% if uses_menu %}
         {% block minisite_title %}
         {% endblock %}
-        <div class="container">
-            <div class="row">
-                <div class="col-12">
-                    <p class="tw-h5-heading d-md-none mt-3">{{ mini_site_title }}</p>
+        {% if mini_site_title %}
+            <div class="container">
+                <div class="row">
+                    <div class="col-12">
+                        <p class="tw-h5-heading d-md-none mt-3">{{ mini_site_title }}</p>
+                    </div>
                 </div>
             </div>
-        </div>
+        {% endif %}
     {% else %}
         {% block minisite_no_menu %}{% endblock %}
     {% endif %}

diff --git a/...gtailpages/templates/wagtailpages/pages/regrets-reporter-landing-page/extension_hero.html b/...gtailpages/templates/wagtailpages/pages/regrets-reporter-landing-page/extension_hero.html
@@ -90,7 +90,7 @@ <h1 class="tw-mb-8 tw-text-white tw-font-changa tw-font-bold tw-text-4xl large:t
     </div>
     <div class="tw-flex tw-flex-col tw-justify-center tw-mt-12 medium:tw-mt-0 large:tw-mt-12">
         <div class="video-container tw-overflow-hidden tw-relative tw-w-full after:tw-pt-[56.25%] after:tw-block after:tw-content-['']">
-            <iframe class="tw-absolute tw-top-0 tw-left-0 tw-w-full tw-h-full" src="https://www.youtube.com/embed/q5Tp1ZUbAFQ" frameborder="0" allowfullscreen></iframe>
+            <iframe class="tw-absolute tw-top-0 tw-left-0 tw-w-full tw-h-full" src="https://www.youtube.com/embed/q5Tp1ZUbAFQ" allowfullscreen></iframe>
         </div>
     </div>
 </div>

diff --git a/network-api/networkapi/wagtailpages/templates/wagtailpages/tags/card-large.html b/network-api/networkapi/wagtailpages/templates/wagtailpages/tags/card-large.html
@@ -3,10 +3,10 @@
 <div class="row card-cta-large my-3 align-items-center my-4">
     <div class="col-12 col-md-6 mb-3 mb-md-0">
         {% image image fill-1080x600-c100 format-jpeg as hero %}
-        <img class="full-bleed-xs d-block d-md-none d-lg-block" src="{{ hero.url }}" class="w-100">
+        <img class="full-bleed-xs d-block d-md-none d-lg-block w-100" src="{{ hero.url }}" />
 
         {% image image fill-600x600-c100 format-jpeg as hero2 %}
-        <img class="d-none d-md-block d-lg-none" src="{{ hero2.url }}" class="w-100">
+        <img class="d-none d-md-block d-lg-none w-100" src="{{ hero2.url }}" />
     </div>
     <div class="col-12 col-md-6">
         <h3 class="tw-h2-heading">{{ title }}</h3>