Skip to content

Commit

Permalink
Revert "[PNI] Improved <title> tags for SEO (#12046)"
Browse files Browse the repository at this point in the history
This reverts commit 95c8f88.
  • Loading branch information
robdivincenzo committed Mar 19, 2024
1 parent 95c8f88 commit bd0d703
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 17 deletions.
12 changes: 2 additions & 10 deletions network-api/networkapi/templates/pages/buyersguide/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,8 @@

{% block page_title %}
{% environment_prefix %}
{# if routable page #}
{% if pageTitle %}
{{ pageTitle }}
{# if custom seo_title for a wagtail page #}
{% elif page.seo_title %}
{{ page.seo_title }}
{# default to page.title #}
{% else %}
{{ page.title }} | {% blocktrans context "“*Privacy Not Included can be localized. This is a reference to the “*batteries not included” mention on toys." %}*Privacy Not Included{% endblocktrans %}
{% endif %}
{% if pageTitle %}{{ pageTitle }}
{% else %}{% blocktrans context "“*Privacy Not Included” can be localized. This is a reference to the “*batteries not included” mention on toys." %}*Privacy Not Included | Shop smart and safe{% endblocktrans %} | Mozilla Foundation{% endif %}
{% endblock %}

{# TODO: consider using a different ga_identifier? #}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def about_page(self, request):
context["pagetype"] = "about"
context["pageTitle"] = pgettext(
"*Privacy Not Included can be localized.",
"How to use *Privacy Not Included | Mozilla Foundation",
"How to use *Privacy Not Included",
)
return render(request, "pages/buyersguide/about/how_to_use.html", context)

Expand All @@ -195,7 +195,7 @@ def about_why_page(self, request):
context["pagetype"] = "about"
context["pageTitle"] = pgettext(
"*Privacy Not Included can be localized.",
"Why we made *Privacy Not Included | Mozilla Foundation",
"Why we made *Privacy Not Included",
)
return render(request, "pages/buyersguide/about/why_we_made.html", context)

Expand All @@ -208,7 +208,7 @@ def about_press_page(self, request):
+ " | "
+ pgettext(
"This can be localized. This is a reference to the “*batteries not included” mention on toys.",
"*Privacy Not Included | Mozilla Foundation",
"*Privacy Not Included",
)
)
return render(request, "pages/buyersguide/about/press.html", context)
Expand All @@ -222,7 +222,7 @@ def about_contact_page(self, request):
+ " | "
+ pgettext(
"This can be localized. This is a reference to the “*batteries not included” mention on toys.",
"*Privacy Not Included | Mozilla Foundation",
"*Privacy Not Included",
)
)
return render(request, "pages/buyersguide/about/contact.html", context)
Expand All @@ -236,7 +236,7 @@ def about_methodology_page(self, request):
+ " | "
+ pgettext(
"This can be localized. This is a reference to the “*batteries not included” mention on toys.",
"*Privacy Not Included | Mozilla Foundation",
"*Privacy Not Included",
)
)
return render(request, "pages/buyersguide/about/methodology.html", context)
Expand All @@ -250,7 +250,7 @@ def about_contest(self, request):
+ " | "
+ pgettext(
"This can be localized. This is a reference to the “*batteries not included” mention on toys.",
"*Privacy Not Included | Mozilla Foundation",
"*Privacy Not Included",
)
)
return render(request, "pages/buyersguide/contest.html", context)
Expand Down Expand Up @@ -309,7 +309,7 @@ def categories_page(self, request, slug):
context["category"] = slug
context["current_category"] = category
context["products"] = products
context["pageTitle"] = f'{category.name} | {gettext("Privacy & Security Guide")}' f" | Mozilla Foundation"
context["pageTitle"] = f'{category.name} | {gettext("Privacy & security guide")}' f" | Mozilla Foundation"
context["template_cache_key_fragment"] = f"{category.slug}_{request.LANGUAGE_CODE}"

# Checking if category has custom metadata, if so, update the share image and description.
Expand Down

0 comments on commit bd0d703

Please sign in to comment.