Closes #2 by changing dotenv variable name #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in Mosuswalks#2, the README tells the user to create a `.env` file with a `CVC` variable in it but the `bot.js` file references a `CV_CODE` variable in the dotenv file which doesn't exists. It's actually called a Card Verification Value (CVV) code and not a CVC code and hence the variable names were adjusted to match that.
to make it clear that the size should be either 'US M 9.5' or 'US 12' or 'W 10' and not 'US M 9.5 / W 11' (which isn't a valid size).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks @Mosuswalks for this amazing project! I really like the simplicity and elegance of it 👏 excited to contribute to it!
This MR closes issue #2 by changing the variable name retrieved from the
.envfile fromCV_CODEtoCVVas outlined by @sjh37 in the issue. However, I decided to go withCVV(Credit Verification Value) instead ofCVCto avoid confusion or accidental mistakes since it is called CVV.On top of that, I found the doc string for the
sizevariable slightly confusing since it did not clear to me that the size string should be either "US M 8.5" or "US W 11" and not "US M 8.5 / W 11". I tried to make that more clear in the additional comment line.