Includes buyer & seller pubkeys and order creation time upon order transition to Active state #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er transition to Active state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the seller as the maker, the information about each trade party's real public keys should be sent upon the hodl invoice confirmation with the
buyer_pubkey&seller_pubkeyas per the documentation. This however was not happening. Another thing that was missing was the order creation time.Please note that for this to work the dependencies must be updated as I'm using a modified
mostro-corewith modifications that can be seen here. Basically just adding these two fields to theSmallOrderstruct.