Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @grunch ,
putting here as an example of possible refactoring idea based on the blog article I shared on telegram:
https://sabrinajewson.org/blog/errors
I like the idea inside seems more elegant also if it's a required an effort in code and many calls to
map_err
when we can have aResult
.Putting here this as draft to share what could be te result, now
settings.rs
has some refactoring i did and results of error are now like this:or
The approach is to avoid a big enum file and distribute errors in relative file, creating more specialized ones.
This will remove also
anyhow
crate.Let me know what you think about...