-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored with notifier pattern #33
Conversation
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 30 files out of 116 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Amazing work! now let's move to keys-management 😃
Refactored with notifier pattern
Refactored with notifier pattern
This PR represents a major refactoring of the App to use the Notifier pattern which makes the application more reactive to user input and interactions with the Mostro daemon and easier to adapt to any changes or additions to the base protocol.
These changes now mean the app supports the following actions:
And their respective UX
This is still alpha software and should not be used with production systems. Check the relay config in
lib/app/config.dart
before adding or taking orders to make sure you are not operating on live data.Order state is presently not persisted between sessions.
This version still uses the
content
field instead ofpayload
and random key assignment. Once MostroP2P/mostro#398 is merged it will be updated accordingly.