fix process exit val

Moonsong-Labs · Oct 30, 2023 · 8bbcefd · 8bbcefd
1 parent 796f639
commit 8bbcefd
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 65 deletions.
diff --git a/.changeset/gorgeous-months-jog.md b/.changeset/gorgeous-months-jog.md
@@ -0,0 +1,5 @@
+---
+"@moonwall/cli": patch
+---
+
+Fix process exit val
diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -62,7 +62,7 @@
   },
   "dependencies": {
     "@acala-network/chopsticks": "^0.8.4",
-    "@moonbeam-network/api-augment": "^0.2400.0",
+    "@moonbeam-network/api-augment": "^0.2500.0",
     "@moonwall/types": "workspace:*",
     "@moonwall/util": "workspace:*",
     "@polkadot/api": "^10.10.1",
@@ -92,7 +92,7 @@
     "viem": "^1.18.0",
     "vitest": "1.0.0-beta.3",
     "web3": "4.2.1",
-    "web3-providers-ws": "4.0.3",
+    "web3-providers-ws": "4.0.7",
     "ws": "^8.14.2",
     "yaml": "^2.3.3",
     "yargs": "^17.7.2"

diff --git a/packages/cli/src/cmds/entrypoint.ts b/packages/cli/src/cmds/entrypoint.ts
@@ -91,8 +91,9 @@ yargs(hideBin(process.argv))
     async (args) => {
       if (args.envName) {
         process.env.MOON_RUN_SCRIPTS = "true";
-        await testCmd(args.envName.toString(), { testNamePattern: args.GrepTest });
-        process.exit(0);
+        (await testCmd(args.envName.toString(), { testNamePattern: args.GrepTest }))
+          ? process.exit(0)
+          : process.exit(1);
       } else {
         console.log("❌ No environment specified");
         console.log(`👉 Run 'pnpm moonwall --help' for more information`);

diff --git a/packages/cli/src/internal/localNode.ts b/packages/cli/src/internal/localNode.ts
@@ -31,7 +31,7 @@ export async function launchNode(cmd: string, args: string[], name: string): Pro
 
   const runningNode = execaCommand(`${cmd} ${args.join(" ")}`, {
     all: true,
-    cleanup: true,
+    cleanup: false,
     detached: false,
   }).pipeAll(logLocation);
 
@@ -155,7 +155,7 @@ async function checkWebSocketJSONRPC(port: number): Promise<boolean> {
 function findPortsByPid(pid: number, retryDelay: number = 10000) {
   for (;;) {
     const command = `lsof -i -n -P | grep LISTEN | grep ${pid} || true`;
-    const { stdout } = execaCommandSync(command, { shell: true });
+    const { stdout } = execaCommandSync(command, { shell: true, cleanup: true });
     const ports: number[] = [];
     const lines = stdout.split("\n");
 

diff --git a/packages/cli/src/lib/globalContext.ts b/packages/cli/src/lib/globalContext.ts
@@ -406,7 +406,7 @@ export interface IGlobalContextFoundation {
 
 async function isPidRunning(pid: number): Promise<boolean> {
   try {
-    await execaCommand(`ps -p ${pid} -o pid=`);
+    await execaCommand(`ps -p ${pid} -o pid=`, { cleanup: true });
     return true;
   } catch {
     return false;

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml