Skip to content

Commit

Permalink
Missing important Semicolon (#34)
Browse files Browse the repository at this point in the history
* onchange patch

Removed attaching an onchange event to core setting. Instead places it in `then` promise.

* Update CHANGELOG.md

* Update module.json

* v1.4.5

switched to await.
Fixed function logic.
Added Comment to end of Line in hopes to make it easy to find to remove.

* Update CHANGELOG.md

* Important semicolon

Added a super important semicolon that was missing
  • Loading branch information
mouse0270 authored Sep 27, 2022
1 parent da05e46 commit c63eff9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# v1.4.6
- Added semicolon to end of `await game.settings.set(...)` was causing reload logic to error

# v1.4.5
- Moved window reload logic to `await` instead of core settings `onchange` event. Fixes incompatibility between MM+ and Ftc

Expand Down
4 changes: 2 additions & 2 deletions js/find-the-culprit.js
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ async function deactivationStep(chosenModules = []) {
await game.settings.set(moduleName, "modules", currSettings);
}

await game.settings.set("core", ModuleManagement.CONFIG_SETTING, original)
await game.settings.set("core", ModuleManagement.CONFIG_SETTING, original);
(foundry.utils.debouncedReload ?? window.location.reload)(); // Temporarily required by foundryvtt/foundryvtt#7740
}

Expand All @@ -357,7 +357,7 @@ async function reactivateModules() {
);
for (let mod in curr.original) original[mod] = curr.original[mod];

await game.settings.set("core", ModuleManagement.CONFIG_SETTING, original)
await game.settings.set("core", ModuleManagement.CONFIG_SETTING, original);
(foundry.utils.debouncedReload ?? window.location.reload)(); // Temporarily required by foundryvtt/foundryvtt#7740
}

Expand Down
4 changes: 2 additions & 2 deletions module.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"bugs": "https://github.com/Moerill/fvtt-find-the-culprit/issues",
"changelog": "https://github.com/Moerill/fvtt-find-the-culprit/blob/master/CHANGELOG.md",
"flags": {},
"version": "1.4.5",
"version": "1.4.6",
"compatibility": {
"minimum": "9",
"verified": "10"
Expand All @@ -32,6 +32,6 @@
"dependencies": [],
"socket": false,
"manifest": "https://raw.githubusercontent.com/Moerill/fvtt-find-the-culprit/master/module.json",
"download": "https://github.com/Moerill/fvtt-find-the-culprit/releases/download/v1.4.5/v1.4.5.zip",
"download": "https://github.com/Moerill/fvtt-find-the-culprit/releases/download/v1.4.6/v1.4.6.zip",
"protected": false
}

0 comments on commit c63eff9

Please sign in to comment.