v0.7.0

CHANGELOG.md

@@ -1,3 +1,6 @@
+# v0.7.0
+* (5e): Added settings option to support for "maximum crits": Changes behaviour of critical damage rolls to maximize the damage of the extra dice for criticals! Thanks to @bsleys for adding this feature!
+
 # v0.6.1
 * Forgot to update module.json to show compatibility with newest FVTT version....
 

dist/module.json

@@ -2,7 +2,7 @@
 	"name": "mess",
 	"title": "Mess - Moerills enhancing super-suit(e)",
 	"description": "This module is a mix of QoL changes, enhancements for my game and stuff i play around with. For a complete feature list check the URL down below.",
-	"version": "0.6.1",
+	"version": "0.7.0",
 	"minimumCoreVersion": "0.6.0",
 	"compatibleCoreVersion": "0.6.2",
 	"author": "Moerill",
@@ -28,5 +28,5 @@
 	],
 	"manifest": "https://raw.githubusercontent.com/Moerill/mess/master/src/module.json",
 	"url": "https://github.com/Moerill/mess",
-	"download": "https://github.com/Moerill/mess/releases/download/v0.6.1/mess.zip"
+	"download": "https://github.com/Moerill/mess/releases/download/v0.7.0/mess.zip"
 }

dist/templates/welcome-screen.html

@@ -22,6 +22,10 @@ <h2></h2>
 	<p style="text-align: right">Want to support development? <a href="https://github.com/Moerill/token-mold#support-the-development">Click here</a></p>
 	<h2></h2>
 <h1>Changelog</h1>
+<h2>v0.7.0</h2>
+<ul>
+	<li>(5e): Added settings option to support for "maximum crits": Changes behaviour of critical damage rolls to maximize the damage of the extra dice for criticals! Thanks to BSleys for adding this feature!</li>
+</ul>
 <h2>v0.6.0</h2>
 <ul>
 	<li>New Feature: You can now specify your items chat flavor using rollable Tables!

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "module-template",
-	"version": "0.6.1",
+	"version": "0.7.0",
 	"description": "",
 	"scripts": {
 		"test": "echo \"Error: no test specified\" && exit 1"

src/module.json

@@ -2,7 +2,7 @@
 	"name": "mess",
 	"title": "Mess - Moerills enhancing super-suit(e)",
 	"description": "This module is a mix of QoL changes, enhancements for my game and stuff i play around with. For a complete feature list check the URL down below.",
-	"version": "0.6.1",
+	"version": "0.7.0",
 	"minimumCoreVersion": "0.6.0",
 	"compatibleCoreVersion": "0.6.2",
 	"author": "Moerill",
@@ -28,5 +28,5 @@
 	],
 	"manifest": "https://raw.githubusercontent.com/Moerill/mess/master/src/module.json",
 	"url": "https://github.com/Moerill/mess",
-	"download": "https://github.com/Moerill/mess/releases/download/v0.6.1/mess.zip"
+	"download": "https://github.com/Moerill/mess/releases/download/v0.7.0/mess.zip"
 }

src/scripts/index.js

@@ -71,4 +71,4 @@ Hooks.on('init', function() {
 // 			options.forEach(e => e.condition = false)
 // 			return [];
 // 		})
-// })
+// })

src/scripts/rolls/dice.js

@@ -196,11 +196,18 @@ export async function rollToHit(ev) {
 		span.classList.add('crit');
 		card.querySelector('.mess-chat-dmg .mess-chat-roll-type').innerHTML += ' - Crit!'
 		card.querySelectorAll('.mess-button-dmg').forEach((e, idx) => {
-			const formula = e.dataset.formula;
-			const r = new Roll(formula);
-			r.alter(0, 2);
-			e.innerHTML = `<i class="fas fa-dice-d20"></i> ${r.formula}`
-			e.dataset.formula = r.formula;
+			const rgx = new RegExp(Die.rgx.die, "g");
+			const formula = e.dataset.formula.replace(rgx, (match, nd, d, mods) => {
+				if (game.settings.get('mess', 'max-critical'))
+						mods = " + " + nd * d + (mods || "");
+				else {
+						nd = nd * 2;
+						mods = mods || "";
+				}
+				return nd + "d" + d + mods;
+			});
+			e.innerHTML = `<i class="fas fa-dice-d20"></i> ${formula}`;
+			e.dataset.formula = formula;
 		});
 	}
 	if (d20 <= fumble)

src/scripts/rolls/modify-rolling.js

@@ -9,11 +9,15 @@ export default function() {
  * Initializes all the hoohks!
  */
 function setupHooks() {
+	CONFIG.Item.entityClass.chatListeners  = chatListeners.bind(CONFIG.Item.entityClass);
+
 	Hooks.on('preCreateChatMessage', preCreateChatMessageHook);
 	Hooks.on('renderActorSheet', actorSheetHook);
 
 	// Bind my own chatListeners to the item class and execute them.
-	Hooks.on('ready', chatListeners.bind(CONFIG.Item.entityClass));
+	// Hooks.on('ready', chatListeners.bind(CONFIG.Item.entityClass));
+
+
 }
 
 /**
@@ -268,8 +272,9 @@ async function actorSheetHook(app, html, data) {
 /**
  * My own chat listeners
  */
-function chatListeners() {
-	const html = $(document.getElementById('chat-log'));
+function chatListeners(html) {
+	if (!html)
+		html = $(document.getElementById('chat-log'));
 	html.on('click', '.card-buttons button', onChatCardAction.bind(this));
 	// html.on('click', '.item-name', this._onChatCardToggleContent.bind(this));
 
@@ -323,7 +328,7 @@ async function onDblClickTarget(ev) {
 	if (!token || !token.visible) return false;
 
 	const pos = token.center;
-	canvas.animatePan({x: pos.x, y: pos.y})
+	canvas.animatePan({x: pos.x, y: pos.y});
 }
 
 async function getTargetToken(ev) {

src/scripts/settings.js

@@ -87,6 +87,16 @@ export class MessSettings extends FormApplication {
 			default: true,
 			type: Object
 		});	
+
+		game.settings.register('mess', 'max-critical', {
+			name: "Activate maximum critical rolls.",
+			hint: "Changes behaviour of critical damage rolls to maximize the damage of the extra dice for criticals!",
+			scope: "world",
+			config: isDnD,
+			default: false,
+			type: Boolean,
+			onChange: () => location.reload()
+		});
 	}
 
 	static get defaultOptions() {

src/templates/welcome-screen.html

@@ -22,6 +22,10 @@ <h2></h2>
 	<p style="text-align: right">Want to support development? <a href="https://github.com/Moerill/token-mold#support-the-development">Click here</a></p>
 	<h2></h2>
 <h1>Changelog</h1>
+<h2>v0.7.0</h2>
+<ul>
+	<li>(5e): Added settings option to support for "maximum crits": Changes behaviour of critical damage rolls to maximize the damage of the extra dice for criticals! Thanks to BSleys for adding this feature!</li>
+</ul>
 <h2>v0.6.0</h2>
 <ul>
 	<li>New Feature: You can now specify your items chat flavor using rollable Tables!