Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put script in iife #171

Merged
merged 1 commit into from
Nov 2, 2023
Merged

put script in iife #171

merged 1 commit into from
Nov 2, 2023

Conversation

PladsElsker
Copy link
Contributor

@PladsElsker PladsElsker commented Nov 2, 2023 •
edited
Loading

I encountered a global variable collision while working on another extension, we shouldn't pollute the global scope.

@ljleb
Copy link
Contributor

ljleb commented Nov 2, 2023

These diffs are painful.

@PladsElsker PladsElsker merged commit 7dd908a into main Nov 2, 2023
2 checks passed
@PladsElsker PladsElsker deleted the clean-global-state branch November 2, 2023 17:32
@PladsElsker
Copy link
Contributor Author

PladsElsker commented Nov 2, 2023 •
edited
Loading

These diffs are painful.

lol
Can I do something about it?
Like, is there a way to fix this next time I have a pr like that?

Maybe 2 commits instead of 1:

  • add top and bottom function def
  • indent code

Something like that?

@ljleb
Copy link
Contributor

ljleb commented Nov 2, 2023 •
edited
Loading

No I don't think so. I mean you can try it but in my experience it did not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljleb ljleb ljleb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PladsElsker @ljleb